Alon Bar-Lev has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
......................................................................
Patch Set 4: (2 inline comments)
Minor comment.
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1380_add_gluster_specific_firewall_config.sql
Line 14: # snmp
Line 15: -A INPUT -p udp --dport 161 -j ACCEPT
Line 16:
Line 17:
Line 18: #REPLACE_WITH_SERVICE_RULES
I prefer template notation of:
@CUSTOM_RULES@
Always replace @CUSTOM_RULES@ either by empty string or by some other rules.
Line 19:
Line 20:
Line 21: # Reject any other input traffic
Line 22: -A INPUT -j REJECT --reject-with icmp-host-prohibited
Line 24: COMMIT
Line 25: ' WHERE option_name = 'IPTablesConfig';
Line 26:
Line 27:
Line 28: INSERT INTO vdc_options (option_name, option_value, version) VALUES
('VirtIPTablesConfig',
space.
Line 29: '
Line 30: # libvirt tls
Line 31: -A INPUT -p tcp --dport 16514 -j ACCEPT
Line 32: # guest consoles
--
To view, visit http://gerrit.ovirt.org/7244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a5958e870d3315316a59e1038101b2511bf8815
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
