Alon Bar-Lev has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 568: select
fn_db_update_config_value('VdsFenceType','alom,apc,bladecenter,drac5,eps,ilo,ipmilan,rsa,rsb,wti,cisco_ucs','2.2');
Line 569: select fn_db_update_config_value('VmGracefulShutdownMessage','The
oVirt Engine is shutting down this Virtual Machine','general');
Line 570: select
fn_db_update_config_value('DisconnectPoolOnReconstruct','0,2,3','general');
Line 571: select
fn_db_update_config_value('SupportBridgesReportByVDSM','false','3.1');
Line 572: select fn_db_update_config_value('IPTablesConfig','
I don't understand how this is added again... I expected only change where
CUSTOM_RULES is...
Have you rebased? or have duplicate?
I see this variable exist above...
Line 573: # oVirt default firewall configuration. Automatically generated by
vdsm bootstrap script.
Line 574: *filter
Line 575: :INPUT ACCEPT [0:0]
Line 576: :FORWARD ACCEPT [0:0]
--
To view, visit http://gerrit.ovirt.org/7244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a5958e870d3315316a59e1038101b2511bf8815
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches