Allon Mureinik has posted comments on this change.
Change subject: core: Replaced getDiskImageDAO with getDiskImageDao
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
love the idea, thanks for the effort!
please address the inline comment provided by other reviewers, though.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 157: protected ImageDao getImageDao() {
Line 158: return getDbFacade().getImageDao();
Line 159: }
Line 160:
Line 161: protected DiskDao getDiskDao() {
It's redundant in AbstractDiskVmCommand - VmCommand has one.
Line 162: return getDbFacade().getDiskDao();
Line 163: }
Line 164:
Line 165: protected SnapshotDao getSnapshotDao() {
....................................................
Commit Message
Line 8:
Line 9: This should help fix Jenkins warning -
Line 10:
Line 11: "VERY confusing to have methods
org.ovirt.engine.core.bll.AbstractDiskVmCommand.getDiskDao()
Line 12: and org.ovirt.engine.core.bll.VmCommand.getDiskDAO()"
Can you please add a link to the relevant jenkins page?
Line 13:
Line 14: Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92
--
To view, visit http://gerrit.ovirt.org/7846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
