Sharad Mishra has posted comments on this change.
Change subject: core: Replaced getDiskImageDAO with getDiskImageDao
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 313: * @return The disk with the correct volume info.
Line 314: */
Line 315: private DiskImage getDiskForVolumeInfo(DiskImage disk) {
Line 316: if (getParameters().getCopyCollapse()) {
Line 317: DiskImage ancestor =
DbFacade.getInstance().getDiskImageDao().getAncestor(disk.getImageId());
Done
Line 318: if (ancestor == null) {
Line 319: log.warnFormat("Can't find ancestor of Disk with ID
{0}, using original disk for volume info.",
Line 320: disk.getImageId());
Line 321: ancestor = disk;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDisksForQuotaIdQuery.java
Line 12: }
Line 13:
Line 14: @Override
Line 15: protected void executeQueryCommand() {
Line 16: List<DiskImage> disks =
DbFacade.getInstance().getDiskImageDao().getAllForQuotaId(getParameters().getQuotaId());
This class does not inherit any getDiskImageDao().
Do you see value in creating a new method for just one use here?
Line 17: for (DiskImage diskImage : disks) {
Line 18: diskImage.getSnapshots().addAll(
Line 19:
ImagesHandler.getAllImageSnapshots(diskImage.getImageId(),
diskImage.getit_guid()));
Line 20: }
....................................................
Commit Message
Line 8:
Line 9: This should help fix Jenkins warning -
Line 10:
Line 11: "VERY confusing to have methods
org.ovirt.engine.core.bll.AbstractDiskVmCommand.getDiskDao()
Line 12: and org.ovirt.engine.core.bll.VmCommand.getDiskDAO()"
Done
Line 13:
Line 14: Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92
--
To view, visit http://gerrit.ovirt.org/7846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
