Gilad Chaplik has uploaded a new change for review. Change subject: core: NPE in runVmOnce (#854977) ......................................................................
core: NPE in runVmOnce (#854977) https://bugzilla.redhat.com/854977 because stateless parameter is Boolean, and we don't initialize it (to false), we get a NPE, because we try to test if it equals to false. Change-Id: I03a4823e7bed1a076a5c1f7d9580e8e28ceaa0f1 Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/7926/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java index 6dda151..1206852 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java @@ -1,5 +1,8 @@ package org.ovirt.engine.core.bll; +import java.util.ArrayList; +import java.util.List; + import org.ovirt.engine.core.bll.job.ExecutionContext; import org.ovirt.engine.core.bll.job.ExecutionHandler; import org.ovirt.engine.core.bll.quota.QuotaManager; @@ -10,9 +13,6 @@ import org.ovirt.engine.core.common.businessentities.VMStatus; import org.ovirt.engine.core.common.vdscommands.CreateVmVDSCommandParameters; import org.ovirt.engine.core.dal.VdcBllMessages; - -import java.util.ArrayList; -import java.util.List; public class RunVmOnceCommand<T extends RunVmOnceParams> extends RunVmCommand<T> { public RunVmOnceCommand(T runVmParams) { @@ -66,7 +66,7 @@ return false; } //Only if this is run-stateless mode we calculate storage quota. - if (!getParameters().getRunAsStateless()) { + if (Boolean.FALSE.equals(getParameters().getRunAsStateless())) { return quotaAcc; } -- To view, visit http://gerrit.ovirt.org/7926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03a4823e7bed1a076a5c1f7d9580e8e28ceaa0f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
