Michael Kublin has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
......................................................................
Patch Set 6: (2 inline comments)
small remarks
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 426: * @see VdsEventListener
Line 427: * @See VdsUpdateRunTimeInfo
Line 428: */
Line 429: @Override
Line 430: public void throttle(Guid vdsId) {
Don't need that check
Line 431: if (log.isDebugEnabled()) {
Line 432: log.debug("try to wait for te engine update the host
memory and cpu stats");
Line 433: }
Line 434:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 669:
Line 670: public boolean isSetNonOperationalExecuted() {
Line 671: return isSetNonOperationalExecuted;
Line 672: }
Line 673:
we don't need that methods, they don't help and not make code clear.
We are writing String s = new String() and not
String makeNewString() { return new String(); }
Line 674: private void setStartTime() {
Line 675: updateStartTime = System.currentTimeMillis();
Line 676: }
Line 677: private void setLastUpdate() {
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
