Doron Fediuck has posted comments on this change. Change subject: core: throttle running of VMs (#843058) ......................................................................
Patch Set 6: (1 inline comment) Hi Roy, just general comments (see inline). Also, did you check what VM compensation will do? ie- if we wait for VM to run, and backend crashes and reloaded. What will happen? Is it re-scheduled? else? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java Line 420: } Line 421: } Line 422: Line 423: /** Line 424: * throttle bulk run of VMs by waiting for the update of run-time to kick in and fire <br> Roy, Since not all programmers are aware of Throttle- http://en.wikipedia.org/wiki/Throttle, I suggest a simpler name to be more helpful when reading it. How about waitVMStartWithTimeout or anything similar? Line 425: * the DecreasePendingVms event. Line 426: * @see VdsEventListener Line 427: * @See VdsUpdateRunTimeInfo Line 428: */ -- To view, visit http://gerrit.ovirt.org/7204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
