Michael Kublin has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 156: saveVmDevicesToDb();
Line 157: }
Line 158:
Line 159: private void saveVmDevicesToDb() {
Line 160: updateAllInTransaction(vmDeviceToSave.values(),
getDbFacade().getVmDeviceDAO());
The problem os sort is not solved here, vmDeviceToSave.values() - these order
is unpredictable, we should sort device here.
Line 161:
Line 162: if (!removedDeviceIds.isEmpty()) {
Line 163:
TransactionSupport.executeInScope(TransactionScopeOption.Required,
Line 164: new TransactionMethod<Void>() {
--
To view, visit http://gerrit.ovirt.org/7641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If316259f9760777c5f85db0880a157021c61a6ba
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
