Yair Zaslavsky has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java
Line 17: */
Line 18: public abstract class MassOperationsGenericDaoDbFacade<T extends
BusinessEntity<ID>, ID extends Serializable>
Line 19: extends DefaultGenericDaoDbFacade<T, ID> implements
MassOperationsDao<T> {
Line 20:
Line 21: public MassOperationsGenericDaoDbFacade(String
entityStoredProcedureName) {
The idea of this class is to run a set of operations on a single connection.
You're correct in general about what you said, but unfortunately spring-jdbc
(or maybe it was jdbc itself with postgres) is lacking support to perform this
+ I assume you don't want to have a dynamic sql for this case.
Line 22: super(entityStoredProcedureName);
Line 23: }
Line 24:
Line 25: @Override
Line 22: super(entityStoredProcedureName);
Line 23: }
Line 24:
Line 25: @Override
Line 26: public void updateAll(Collection<T> entities) {
Debatable :) I remind you that for example spring-ldap has more than 5 versions
of search
Line 27: updateAll(getProcedureNameForUpdate(),entities);
Line 28: for (T entity : entities) {
Line 29:
getCallsHandler().executeModification(getProcedureNameForUpdate(),
Line 30: createFullParametersMapper(entity));
Line 32: }
Line 33:
Line 34: @Override
Line 35: public void updateAll(String procedureName, Collection<T>
entities) {
Line 36: if (procedureName == null) {
It's another "version" of the above API. I think a user would actually want to
use a method with less parameters where possible. About null - you're right,
this should be documented.
Line 37: procedureName = getProcedureNameForUpdate();
Line 38: }
Line 39: for (T entity : entities) {
Line 40: getCallsHandler().executeModification(procedureName,
--
To view, visit http://gerrit.ovirt.org/7641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If316259f9760777c5f85db0880a157021c61a6ba
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
