Oved Ourfali has posted comments on this change.
Change subject: engine: Peer probe gluster servers on bootstrap
......................................................................
Patch Set 12: Looks good to me, but someone else must approve
(1 inline comment)
Have a small question on the flow. See comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 216: List<GlusterServerInfo> glusterServers =
getGlusterPeers(upServer.getId());
Line 217: if (glusterServers.size() == 0) {
Line 218:
setNonOperational(NonOperationalReason.GLUSTER_PEER_LIST_FAILED);
Line 219: } else if (!hostExists(glusterServers, getVds())) {
Line 220: if (!glusterPeerProbe(upServer.getId(),
getVds().gethost_name())) {
If probing failed from this host, is it possible that it would work from
another one?
Would you benefit in trying to probe it from a different one?
Line 221:
setNonOperational(NonOperationalReason.GLUSTER_PEER_PROBE_FAILED);
Line 222: }
Line 223: }
Line 224: }
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13c8de35ac596d89d2a9c631c4a8ef26996ea860
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
