Yair Zaslavsky has posted comments on this change.
Change subject: engine: Peer probe gluster servers on bootstrap
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 204: // If the cluster already having Gluster servers, get an up
server
Line 205: if (vdsList != null && vdsList.size() > 0) {
Line 206: VDS upServer = null;
Line 207: for (VDS vds : vdsList) {
Line 208: if (!Guid.OpEquality(getVdsId(), vds.getId())) {
I would prefer , if possible that u use equals. This OpEquality method should
be removed, IMHO
Line 209: upServer = vds;
Line 210: break;
Line 211: }
Line 212: }
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13c8de35ac596d89d2a9c631c4a8ef26996ea860
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
