Allon Mureinik has posted comments on this change.
Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the
same pool(#845838)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
see inline question.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1144:
Line 1145: }
Line 1146: return domainsInProblems;
Line 1147: }
Line 1148: });
Is the formatting change above an integral part of the patch?
it makes it somewhat hard to read.
Line 1149: if (domainsInProblems != null) {
Line 1150: lockIrsProxyLockObject();
Line 1151: try {
Line 1152: // during reconstruct master we do not want to
update
--
To view, visit http://gerrit.ovirt.org/7982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0dfb227b014af602e5bd1ab952d7c543992aa0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
