Michael Kublin has posted comments on this change.

Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the 
same pool(#845838)
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 54:     }
Line 55: 
Line 56:     @Override
Line 57:     protected boolean canDoAction() {
Line 58:         boolean toReturn = false;
starvation, reconstruct can never run, because of VdsManager.OnTimer at case of 
couple vdsms and master domain in problem.
Still don't understand what you are trying to solve here.
Line 59:         if 
(IrsBrokerCommand.tryLockIrsProxyData(getStoragePool().getId())) {
Line 60:             try {
Line 61:                 toReturn = performChecks();
Line 62:             } catch (Exception e) {


--
To view, visit http://gerrit.ovirt.org/7982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0dfb227b014af602e5bd1ab952d7c543992aa0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to