Juan Hernandez has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit ......................................................................
Patch Set 1: No, it is not a duplication. Any thing that is included in an "import ..." statement in the Java code should be explicitly included in the POM of the component, otherwise depending on how transitive dependencies are computed it may or may not work. In this particular this doesn't work when I build in Fedora 18. Note also that I am not including the version number, that is taken from the root POM. -- To view, visit http://gerrit.ovirt.org/6597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id46b4d7a360348a67fa7430b4af0eefa3d76fe2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
