Allon Mureinik has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit ......................................................................
Patch Set 1: Looks good to me, but someone else must approve Thanks Juan, that was enlightening. Just so I get the rules of thumb clear in my head: 1. If your code imports something - a dependency should be added to the pom.xml of the project 2. If that import depends on something else - don't add it to the pom (e.g., if I added commons-logging, I should not explicitly add log4j, maven's dependency mechanism should handle that 3. versions should be defined in the master pom, not in each project. Is that correct? -- To view, visit http://gerrit.ovirt.org/6597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id46b4d7a360348a67fa7430b4af0eefa3d76fe2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
