Martin Betak has posted comments on this change. Change subject: frontend: add vm-devices sub tab ......................................................................
Patch Set 1: Code-Review+1 (2 comments) looks good, but needs also Tomas' eye https://gerrit.ovirt.org/#/c/39795/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java: Line 127: return ""; //$NON-NLS-1$ Line 128: } Line 129: } Line 130: }; Line 131: bootOrderColumn .makeSortable(); extra space? Line 132: getTable().addColumn(bootOrderColumn , constants.deviceBootOrderAlias(), "70px"); //$NON-NLS-1$ Line 133: } Line 134: Line 135: private void addSpecParamsColumn() { Line 138: public String getValue(VmDevice device) { Line 139: return device.getSpecParams().toString(); Line 140: } Line 141: }; Line 142: specParamsColumn .makeSortable(); extra space? Line 143: getTable().addColumn(specParamsColumn , constants.deviceSpecParamsAlias(), "300px"); //$NON-NLS-1$ Line 144: } Line 145: -- To view, visit https://gerrit.ovirt.org/39795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73ab7de18bd05ef2f19a6abb0c9afbc7d88ff6e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
