Tomas Jelinek has posted comments on this change. Change subject: frontend: add vm-devices sub tab ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39795/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java: Line 35: addSpecParamsColumn(); Line 36: } Line 37: Line 38: private void addGeneralTypeColumn() { Line 39: // TODO: replace with icon are you planning a followup patch? Or do you want to make it in this one? If you are planning a followup please track it in bugzilla and remove this comment. I have personally never seen the todo to be actually implemented because found in code ;) Line 40: final AbstractTextColumn<VmDevice> deviceGeneralTypeColumn = new AbstractTextColumn<VmDevice>() { Line 41: @Override Line 42: public String getValue(VmDevice device) { Line 43: return device.getType().name(); -- To view, visit https://gerrit.ovirt.org/39795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73ab7de18bd05ef2f19a6abb0c9afbc7d88ff6e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
