Allon Mureinik has uploaded a new change for review. Change subject: userportal,webadmin: ClusterModel FindBugs ......................................................................
userportal,webadmin: ClusterModel FindBugs In StoragePool_SelectedItemChanged, selectedDataCenter is validated to be non-null in the beginning of the method, so further checks are redundant, and can be safely removed. Change-Id: Id3d2dbe60db232d07f463af96a3b05b9513a40e6 Signed-off-by: Allon Mureinik <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/8197/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java index c81f29e..6a4bbcc 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java @@ -947,8 +947,7 @@ } } }; - AsyncDataProvider.GetDataCenterVersions(_asyncQuery, selectedDataCenter == null ? null - : (NGuid) (selectedDataCenter.getId())); + AsyncDataProvider.GetDataCenterVersions(_asyncQuery, selectedDataCenter.getId()); } public boolean Validate(boolean validateCpu) -- To view, visit http://gerrit.ovirt.org/8197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3d2dbe60db232d07f463af96a3b05b9513a40e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
