Amit Aviram has posted comments on this change.

Change subject: core: QuotaStorageDependent removal in ExtendImageSizeCommand.
......................................................................


Patch Set 1: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/39866/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java:

Line 183: 
> shouldn't we still validate that there's enough quota for the additional si
This is done already in UpdateVmDiskCommand --> 
getQuotaStorageConsumptionParameters

(The check is in the infra, but it request the right amount over there..)


-- 
To view, visit https://gerrit.ovirt.org/39866
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Amit Aviram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to