Roy Golan has posted comments on this change.
Change subject: engine: Run Once dialog ingores emtpy boot options (#857848)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 136: getVm().setLastStartTime(new Date());
Line 137: }
Line 138:
Line 139: /**
Line 140: * By default use default boot sequence. This method can be
overridden to it up according to the RunVmParams.
pls rephrase "this method can be overridden..."
Line 141: */
Line 142: protected void refreshBootSequenceParameter(RunVmParams
runVmParameters) {
Line 143: getVm().setboot_sequence(getVm().getdefault_boot_sequence());
Line 144: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 65: * is used when VM is reloaded from the DB while its parameters
hasn't been persisted (e.g. when running 'as once')
Line 66: */
Line 67: @Override
Line 68: protected void refreshBootParameters(RunVmParams runVmParameters) {
Line 69: super.refreshBootParameters(runVmParameters);
the super is really not needed here and also the call preforms twice
setboot_seq.
I know you tried to keep a "template" style here but its currently an abuse.
wont this be enough?
RunVmCommand
protected void refreshBootParameters(...)
// inline refreshBootSequenceParameter
RunVmOnceCommand
protected void refreshBootParameters(...)
// set initrd,kernel and custom properties
// set boot sequence from params
Line 70:
Line 71: getVm().setinitrd_url(runVmParameters.getinitrd_url());
Line 72: getVm().setkernel_url(runVmParameters.getkernel_url());
Line 73: getVm().setkernel_params(runVmParameters.getkernel_params());
--
To view, visit http://gerrit.ovirt.org/8083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32e59783d9c4d8e8b61ec96c6bae5577fc59756c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
