Roy Golan has posted comments on this change.
Change subject: engine: Run Once dialog ingores emtpy boot options (#857848)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 65: * is used when VM is reloaded from the DB while its parameters
hasn't been persisted (e.g. when running 'as once')
Line 66: */
Line 67: @Override
Line 68: protected void refreshBootParameters(RunVmParams runVmParameters) {
Line 69: super.refreshBootParameters(runVmParameters);
but imagine that someone (bad case would be that no one from our team) will
change the super refreshBootParams to set a state of something:
refereshBootParams(...)
x++
boom! we have counted twice. I'm just saying its fragile and error-prone.
moreover I think the call from attachCD is redundant and could be removed. can
you verify that?
Line 70:
Line 71: getVm().setinitrd_url(runVmParameters.getinitrd_url());
Line 72: getVm().setkernel_url(runVmParameters.getkernel_url());
Line 73: getVm().setkernel_params(runVmParameters.getkernel_params());
--
To view, visit http://gerrit.ovirt.org/8083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32e59783d9c4d8e8b61ec96c6bae5577fc59756c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
