Liron Aravot has posted comments on this change.
Change subject: engine:Validate maximum number of hosts in DC.(#771699)
......................................................................
Patch Set 14: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
Line 15: import org.ovirt.engine.core.utils.linq.Function;
Line 16: import org.ovirt.engine.core.utils.linq.LinqUtils;
Line 17:
Line 18: @InternalCommandAttribute
Line 19: @LockIdNameAttribute(isWait = true)
there was already a logic in the canDoAction of this command.
the check is added here because it's the only place it can be added
efficiently, the vds spm id is the host number in the cluster, that way we can
'reserve' place to the host in the target dc and still reserve it a place in
the source dc so in case of unsuccessful move he will be back to the source DC.
if we perform this operation not in the vdsspmid command that host place in the
source dc can be taken by another added host which will cause to the break of
the flow.
Line 20: public class AddVdsSpmIdCommand<T extends VdsActionParameters> extends
VdsCommand<T> {
Line 21: private List<vds_spm_id_map> vds_spm_id_mapList;
Line 22:
Line 23: /**
--
To view, visit http://gerrit.ovirt.org/6514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
