Michael Kublin has posted comments on this change.
Change subject: engine:Validate maximum number of hosts in DC.(#771699)
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
Line 58: &&
!oldGroup.getstorage_pool_id().equals(getVdsGroup().getstorage_pool_id())
Line 59: || oldGroup.getstorage_pool_id() == null
Line 60: && getVdsGroup().getstorage_pool_id() != null) {
Line 61: for (VdsStatic vds :
getVdsStaticDAO().getAllForVdsGroup(oldGroup.getId())) {
Line 62: VdsActionParameters parameters = new
VdsActionParameters(vds.getId());
Lets will think, we have a check inside canDoAction() of AddVdsSpmId, which
should count a number of host, so now we have 100 and we are adding 200, we
will fail on 101. And we will perform rollback of everything, what that
rollback will do in our system I don't want to imagine.
I understand that the most important is to solve a bug, but maybe to think a
little, at least one step forward.
Line 63: if (getVdsGroup().getstorage_pool_id() != null) {
Line 64: VdcReturnValueBase addVdsSpmIdReturn =
Line 65:
getBackend().runInternalAction(VdcActionType.AddVdsSpmId, parameters);
Line 66: if (!addVdsSpmIdReturn.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/6514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
