Federico Simoncelli has posted comments on this change. Change subject: core: log stacktraces for failed VDSCommandBase calls ......................................................................
Patch Set 1: > I'm fine with that, as long as any non critical exception is also cleaned up > later on as they get reported. Sure, just let me know if I have to filter anything else. > btw, which exception stack trace did you miss in your debugging? Since the general approach for the VDS command is to not bubble the exceptions, and instead return null values, sometimes you see NullPointerExceptions after a failed command (but without a stack trace you don't know where/how it happened). Anyway in general I think it's better to bubble the exceptions appropriately. -- To view, visit http://gerrit.ovirt.org/8243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19d03f42a061531757daf870a6ac8eed34c2f992 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
