Ayal Baron has posted comments on this change.
Change subject: core: log stacktraces for failed VDSCommandBase calls
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 95: log.errorFormat("Command {0} execution failed. Error: {1}",
Line 96: getCommandName(),
Line 97: ExceptionUtils.getMessage(ex));
Line 98: } else {
Line 99: logException(ex);
if you implement Allon's suggestion below then this entire if clause should go
into above if clause and have an else with the generic logException.
Line 100: }
Line 101: }
Line 102:
Line 103: protected void setVdsNetworkError(VDSNetworkException ex) {
--
To view, visit http://gerrit.ovirt.org/8243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d03f42a061531757daf870a6ac8eed34c2f992
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
