Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Make Bookmark entity a JPA entity ......................................................................
Patch Set 60: (3 comments) https://gerrit.ovirt.org/#/c/33836/60/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java: Line 31: } Line 32: Line 33: @Override Line 34: public List<Bookmark> getAll() { Line 35: return entityManager.createQuery("select b from Bookmark b", Bookmark.class).getResultList(); > the returned list is attached to the context. shouldn't it be detached like Done in the base class. Line 36: } https://gerrit.ovirt.org/#/c/33836/60/backend/manager/modules/dal/src/test/resources/test-beans.xml File backend/manager/modules/dal/src/test/resources/test-beans.xml: Line 44: </bean> Line 45: Line 46: <bean id="engineDataSource" class="org.ovirt.engine.core.dao.BaseDAOTestCase" Line 47: factory-method="getDataSource"/> Line 48: > seems like this file can be excluded from this patch. Done Line 49: <bean id="transactionManagerJPA" class="org.springframework.orm.jpa.JpaTransactionManager"> Line 50: <property name="entityManagerFactory" ref="entityManagerFactory" /> Line 51: </bean> Line 52: https://gerrit.ovirt.org/#/c/33836/60/packaging/dbscripts/vm_pools_sp.sql File packaging/dbscripts/vm_pools_sp.sql: Line 265: RETURNS SETOF vm_pools_view STABLE Line 266: AS $procedure$ Line 267: BEGIN Line 268: RETURN QUERY SELECT DISTINCT pools.* Line 269: FROM vm_pools_view pools > please replace tab with space and indent the query to start from the same p Done. Not a part of the patch anymore. Line 270: INNER JOIN user_vm_pool_permissions_view ON user_id = v_user_id AND entity_id = pools.vm_pool_id; Line 271: END; $procedure$ -- To view, visit https://gerrit.ovirt.org/33836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I162f1c22d32b16732ed50a7f6378f8d3e765141a Gerrit-PatchSet: 60 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
