Liran Zelkha has posted comments on this change. Change subject: core: Make Bookmark entity a JPA entity ......................................................................
Patch Set 61: (3 comments) https://gerrit.ovirt.org/#/c/33836/61/backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml File backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml: Line 4: version="2.0"> Line 5: <persistence-unit name="ovirt"> Line 6: <provider>org.hibernate.ejb.HibernatePersistence</provider> Line 7: <non-jta-data-source>java:/ENGINEDataSource</non-jta-data-source> Line 8: <class>org.ovirt.engine.core.common.businessentities.Bookmark</class> > since we expect this element type to constantly grow, wouldn't we rather ha Can't change since the XSD specifics the order of the elements. Note that the solution in the test (specify the package) doesn't work in JBoss. Line 9: <properties> Line 10: <property name="hibernate.dialect" value="org.hibernate.dialect.PostgreSQLDialect" /> Line 11: <property name="jboss.entity.manager.jndi.name" value="java:/ovirtEM"/> Line 12: <property name="jboss.entity.manager.factory.jndi.name" value="java:/ovirtEMF"/> https://gerrit.ovirt.org/#/c/33836/61/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java: Line 20: private static final long serialVersionUID = 8177640907822845847L; Line 21: Line 22: @Id Line 23: @Column(name = "bookmark_id") Line 24: @Type(type = "org.ovirt.engine.core.dao.jpa.GuidUserType") > isn't there an option to match the Guid type to GuidUserType without declar No - we always need to supply the type (at least so the documentation says, and I can't make it work without it). So I threw away the package-info.java file. We don't need it for now. Line 25: private Guid id; Line 26: Line 27: @Size(max = BusinessEntitiesDefinitions.BOOKMARK_NAME_SIZE) Line 28: @Column(name = "bookmark_name") https://gerrit.ovirt.org/#/c/33836/61/backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml File backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml: Line 1: <persistence xmlns="http://java.sun.com/xml/ns/persistence"; version="2.0"> Line 2: <persistence-unit name="ovirt-test"> Line 3: <provider>org.hibernate.ejb.HibernatePersistence</provider> Line 4: <class>org.ovirt.engine.core.common.businessentities.Bookmark</class> > same comment: since we expect this element type to constantly grow, wouldn' I fixed it to provide just the package - so we won't need to add more lines. In any case - we can't change the order of the tags. Eclipse shows an error in the editor. Line 5: <properties> Line 6: <property name="hibernate.dialect" value="org.hibernate.dialect.PostgreSQLDialect" /> Line 7: </properties> Line 8: </persistence-unit> -- To view, visit https://gerrit.ovirt.org/33836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I162f1c22d32b16732ed50a7f6378f8d3e765141a Gerrit-PatchSet: 61 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
