Tal Nisan has posted comments on this change. Change subject: core: Check attached VMs snapshot status when moving a disk ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40080/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 186: SnapshotsValidator snapshotsValidator = getSnapshotsValidator(); Line 187: boolean returnValue = true; Line 188: for (Pair<VM, VmDevice> pair : getVmsWithVmDeviceInfoForDiskId()) { Line 189: VM vm = pair.getFirst(); Line 190: returnValue = returnValue && validate(snapshotsValidator.vmNotInPreview(vm.getId())) Uploaded bad revision by mistake, the returnValue show be at the end of the expression Line 191: && validate(snapshotsValidator.vmNotDuringSnapshot(vm.getId())); Line 192: } Line 193: return returnValue; Line 194: } -- To view, visit https://gerrit.ovirt.org/40080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
