Tal Nisan has posted comments on this change.

Change subject: core: Check attached VMs snapshot status when moving a disk
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40080/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java:

Line 96:                 && validateSourceStorageDomain()
Line 97:                 && validateDestStorage()
Line 98:                 && checkTemplateInDestStorageDomain()
Line 99:                 && validateSpaceRequirements()
Line 100:                 && validateVmSnapshotStatus()
> I assume this is inherited by LSM?
Yes, LiveMigrateDiskCommand inherits from this command and calls 
super.canDoAction()
Line 101:                 && checkCanBeMoveInVm()
Line 102:                 && checkIfNeedToBeOverride()
Line 103:                 && setAndValidateDiskProfiles();
Line 104:     }


-- 
To view, visit https://gerrit.ovirt.org/40080
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Amit Aviram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to