Juan Hernandez has posted comments on this change. Change subject: restapi: Add the "max" matrix parameter implicitly ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40140/2/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java: Line 372: results.add(link); Line 373: } Line 374: } Line 375: Line 376: private void handlePut(String prefix, Collection<DetailedLink> results, Class<?> returnType) { > Why did you change this signature? Because the "handleGet" method needs to receive the "Class<?>", not it string representation, thus I moved the conversion to string to the called method, and since both "handleGet" and "handlePut" are called from the same place I modified both for consistency. Line 377: String returnTypeStr = getReturnTypeStr(returnType); Line 378: DetailedLink link = new RsdlBuilder.LinkBuilder().url(prefix).rel(UPDATE).requestParameter(returnTypeStr).responseType(returnTypeStr).httpMethod(HttpMethod.PUT).build(); Line 379: addAsyncMatrixParameter(link); Line 380: results.add(link); -- To view, visit https://gerrit.ovirt.org/40140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacf0e520d716b0df84e7b6e7b57ffff5911cb1c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
