Tomas Jelinek has posted comments on this change. Change subject: core, webadmin: removed duplicity, reused UpdateNicsParametersFactory ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40033/2/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml: Line 252: <include name="common/utils/SizeConverter.java"/> Line 253: <include name="common/utils/CommonConstants.java"/> Line 254: <include name="common/businessentities/Entities.java"/> Line 255: <include name="common/utils/ToStringBuilder.java"/> Line 256: <include name="common/utils/UpdateNicsParametersFactory.java"/> > this UpdateNicsTemplateInterfaceParametersFactory is used here: org.ovirt.e ah yeah, I have missed that it is a superclass of it. You are right, it has to be here. Line 257: <include name="common/utils/UpdateNicsTemplateInterfaceParametersFactory.java"/> Line 258: Line 259: Line 260: <!-- TODO: Remove when UI will be refactored to use FenceProxySourceType --> -- To view, visit https://gerrit.ovirt.org/40033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b121ffacdda2e40d9ad266507249e9f00dd3327 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
