Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java
Line 59: }
Line 60: }
Line 61:
Line 62: private BrickDetails copyBrickDetails(BrickDetails brick,
BrickDetails entityBrick) {
Line 63: brick.setBrickProperties(entityBrick.getBrickProperties());
Should be ok I think. These (copy*) methods are used when the vdsm verb is
invoked with different options to fetch different kinds of volume details, and
then aggregate the data in a single object of GlusterVolumeAdvancedDetails. The
original objects (from which data is being copied) are not used later on.
Line 64: return brick;
Line 65: }
Line 66:
Line 67: public void copyClientsFrom(GlusterVolumeAdvancedDetails entity) {
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
