Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 10: (3 inline comments)
More comments.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java
Line 62:
expectedVolumeAdvancedDetails.setBrickDetails(getBrickDetails());
Line 63: }
Line 64:
Line 65: private List<BrickDetails> getBrickDetails() {
Line 66: List<BrickDetails> brickDetialsList = new
ArrayList<BrickDetails>();
Why not use Collections.singletonList ?
Line 67: BrickDetails brickDetails = new BrickDetails();
Line 68: brickDetails.setBrickProperties(getBrickProperties());
Line 69: brickDetails.setClients(getClientInfo());
Line 70: brickDetails.setMemoryStatus(getMemoryStatus());
Line 82: return brickProperties;
Line 83: }
Line 84:
Line 85: private List<GlusterClientInfo> getClientInfo() {
Line 86: List<GlusterClientInfo> clientInfoList = new
ArrayList<GlusterClientInfo>();
Same as before
Line 87: GlusterClientInfo clientInfo = new GlusterClientInfo();
Line 88: clientInfo.setBytesRead(836);
Line 89: clientInfo.setBytesWritten(468);
Line 90: clientInfo.setHostname(SERVER_NAME + ":1006");
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterClientInfo.java
Line 11: private static final long serialVersionUID = 4426819375609665363L;
Line 12:
Line 13: private String hostname;
Line 14:
Line 15: private Integer clientPort;
why are these Integer and not int?
Can they be null?
If not - change to int.
Line 16:
Line 17: private Integer bytesRead;
Line 18:
Line 19: private Integer bytesWritten;
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
