Tomas Jelinek has posted comments on this change. Change subject: webadmin: improve error checking on import dialog ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40310/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java: Line 635: && getClusterQuota().getIsValid(); Line 636: } Line 637: Line 638: public void setItems(final Collection value, final Guid storageDomainId) { Line 639: Frontend.getInstance().runQuery(VdcQueryType.GetAllVms, getAllVms? It can be hundreds or thousands. This could kill your browser completely. You should be able to either use the search query which returns all you need (e.g. by name or id) or write a new query which does this for you. But this query is way too expensive I'd say. Line 640: new VdcQueryParametersBase(), Line 641: new AsyncQuery(this, new INewAsyncCallback() { Line 642: Line 643: @Override -- To view, visit https://gerrit.ovirt.org/40310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
