Arik Hadas has posted comments on this change. Change subject: webadmin: improve error checking on import dialog ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40310/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java: Line 615: return true; Line 616: } Line 617: Line 618: @SuppressWarnings("unchecked") Line 619: public void setItems(final Collection value, final Guid storageDomainId) { > since createSearchPattern expects value to be Collection<VM>, can we propag well.. I can propagate it to setItems' signature, but not on level up (ImportVmFromExportDomainModel#init) because it is called from VmBackupModel that cannot use generics to indicate that it works with VM items because TemplateBackupModel extends it... so do you prefer the supressWarnings to appear in the 'init' method instead? Line 620: Frontend.getInstance().runQuery(VdcQueryType.Search, Line 621: new SearchParameters(createSearchPattern(value), SearchType.VM), Line 622: new AsyncQuery(this, new INewAsyncCallback() { Line 623: -- To view, visit https://gerrit.ovirt.org/40310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
