Allon Mureinik has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
......................................................................
Patch Set 13: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStopTaskHandler.java
Line 99: @Override
Line 100: public AsyncTaskType getRevertTaskType() {
Line 101: return AsyncTaskType.deleteImage;
Line 102: }
Line 103: */
should be removed, of course.
Line 104: @Override
Line 105: protected void beforeTask() {
Line 106: // Split the image
Line 107: VmReplicateDiskParameters migrationCompleteParams = new
VmReplicateDiskParameters
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 229: // Event Notification
Line 230: AddEventSubscription(1100),
Line 231: RemoveEventSubscription(1101),
Line 232:
Line 233:
introduced by mistake, shouldn't be a part of this patch
Line 234: // UI User Tabs
Line 235: DataCenters(1200),
Line 236: Clusters(1201),
Line 237: Hosts(1202),
--
To view, visit http://gerrit.ovirt.org/8105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I253891a0a18863086e36a9b17d008cebbc77adc1
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
