Ori Liel has posted comments on this change. Change subject: restapi: Fix possible version mismatch (#1206068) ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40085/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java: Line 291: } Line 292: Line 293: private API addSystemVersion(API api) { Line 294: String productVersion = getConfigurationValueDefault(String.class, Line 295: ConfigurationValues.ProductRPMVersion); > This is easy to solve adding a new "full" or similar property to the backen I'm apprehensive about adding 'full' to Version. Version is referenced about 1500 times in the application, and equals() and hashCode() are overriden in it. I'm not sure what would be the implication of adding fullVersion to these methods. About Capabilities, I wrote that this change was not extended to BackendCapabilitiesResource because there the use of version is different and only major and minor are considered. What do you think? IIUC you're ok with me merging it as is, so I think I'll do that and then make changes if necessary pending further discussion. Line 296: BrandingManager obrand = BrandingManager.getInstance(); Line 297: api.setProductInfo(new ProductInfo()); Line 298: api.getProductInfo().setName(obrand.getMessage("obrand.backend.product")); Line 299: api.getProductInfo().setVendor(obrand.getMessage("obrand.backend.vendor")); -- To view, visit https://gerrit.ovirt.org/40085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bd123c2352db229e52bdbd3f1e2db4ac72018a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Gerri T. Hooks <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
