Ori Liel has posted comments on this change. Change subject: restapi: Fix possible version mismatch (#1206068) ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40085/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProductVersionQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProductVersionQuery.java: Line 16: */ Line 17: public class GetProductVersionQuery<P extends VdcQueryParametersBase> extends QueriesCommandBase<P> { Line 18: Line 19: public static final String RPM_REG_EX = "^\\d+\\.\\d+\\.\\d+"; Line 20: public static final String VDC_VERSION_REG_EX = "^\\d+\\.\\d+\\.\\d+\\.\\d+"; > Just a minor suggestion: since Java 7 you can use named groups in regular e done Line 21: Line 22: public GetProductVersionQuery(P parameters) { Line 23: super(parameters); Line 24: } -- To view, visit https://gerrit.ovirt.org/40085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bd123c2352db229e52bdbd3f1e2db4ac72018a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Gerri T. Hooks <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
