Allon Mureinik has posted comments on this change.
Change subject: webadmin, core: Use NFS v3 as default
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Looks OK, see suggestions inline.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 41: }
Line 42:
Line 43: public static Map<String, String> CreateStructFromConnection(final
storage_server_connections connection,
Line 44: final storage_pool storage_pool) {
Line 45: class ConnParamMap extends HashMap<String, String> {
Consider moving this to a top-level class in the commons package (e.g.,
DefaultValueMaps).
Line 46: void put(String key, Object value, Object def) {
Line 47: put(key, value != null ? value.toString() :
def.toString());
Line 48: }
Line 49: void putIfNotEmpty(String key, Object value) {
Line 42:
Line 43: public static Map<String, String> CreateStructFromConnection(final
storage_server_connections connection,
Line 44: final storage_pool storage_pool) {
Line 45: class ConnParamMap extends HashMap<String, String> {
Line 46: void put(String key, Object value, Object def) {
can't default be a String?
Line 47: put(key, value != null ? value.toString() :
def.toString());
Line 48: }
Line 49: void putIfNotEmpty(String key, Object value) {
Line 50: if (value != null && !"".equals(value.toString())) {
--
To view, visit http://gerrit.ovirt.org/8242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I831ecc7050a5487d5365efb94342a3c170dddc6c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
