Ayal Baron has posted comments on this change.
Change subject: webadmin, core: Use NFS v3 as default
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 74: // For protocol_version - null in the db indicates auto
version negotation,
Line 75: // iff the parameter is sent to vdsm. If
AdvancedNFSOptionsEnabled is
Line 76: // false--the default for compatibility versions <
3.1--then the parameter
Line 77: // is not passed to vdsm, in which case vdsm mounts the
storage as NFSv3.
Line 78: // This prevents unexpected changes to existing v3 domains
during upgrade.
does this mean that in 3.1 compatibility level a parameter is always sent to
vdsm?
if so, that would always override the vdsm.conf nfs options and user would have
no way of overriding this.
In addition, since we unfortunately do not (yet) support editing the options
after domain creation (which means upgraded domains cannot be changed) then
behaviour will not be preserved.
Line 79: con.put("protocol_version", connection.getNfsVersion(),
"auto");
Line 80: con.putIfNotEmpty("timeout", connection.getNfsTimeo());
Line 81: con.putIfNotEmpty("retrans", connection.getNfsRetrans());
Line 82: }
--
To view, visit http://gerrit.ovirt.org/8242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I831ecc7050a5487d5365efb94342a3c170dddc6c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
