Liron Aravot has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
Line 33: }
Line 34:
Line 35: @Override
Line 36: public void compensate() {
Line 37: revertTask();
lets say that we have a command, addX which it's revert command is removeX,
if we have storage failure for example, won't be encounter infine calls between
addX and removeX? I guess that we might need to add some indiation in order to
prevent it.
furthermore, i think that we might need to add 'smart handling' to the vdsm
errors. if we fail on a task for specific reason we might not even need to run
the revert task.
Line 38: addTask(cmd.runVdsCommand(getRevertVDSCommandType(),
getRevertVDSParameters()));
Line 39: }
Line 40:
Line 41: private void addTask(VDSReturnValue vdsReturnValue) {
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
