Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
Line 8: import org.ovirt.engine.core.common.vdscommands.VDSParametersBase;
Line 9: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
Line 10: import org.ovirt.engine.core.compat.Guid;
Line 11:
Line 12: public abstract class AbstractSPMAsyncTaskHandler<C extends
CommandBase<?>> implements SPMAsyncTaskHandler {
There is something I don't understand , when I compare to the detailed design.
In the detailed design I see SPMAsyncTaskHandler and EntireCommand.... Handler.
What is AbstractSPMAsyncTaskHandler? I thought that according to the design we
need just one class to handle the backward compatibility of invoking task mgmt
code that relies at CommandBase.
Line 13:
Line 14: private C cmd;
Line 15:
Line 16: public AbstractSPMAsyncTaskHandler(C cmd) {
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
