Kanagaraj M has posted comments on this change. Change subject: webadmin : Handle multi-tab validation error ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40680/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java: Line 264: Line 265: @Override Line 266: public void setMessage(String msg) { Line 267: super.setMessage(msg); Line 268: errorMsgLabel.setText(msg); Do we still need this? Instead the following way should be used to make the validations uniform. Line 269: } Line 270: Line 271: @Override Line 272: public void handleValidationErrors(GlusterVolumeSnapshotModel object) { Line 270: Line 271: @Override Line 272: public void handleValidationErrors(GlusterVolumeSnapshotModel object) { Line 273: StringBuilder generalTabErrorBuilder = new StringBuilder(); Line 274: if (!snapshotNameEditor.isValid()){ Why do we handle this as special one? Line 275: appendErrors(Collections.singletonList(constants.volumeSnapshotNamePrefixLabel()), generalTabErrorBuilder); Line 276: appendErrors(object.getSnapshotName().getInvalidityReasons(), generalTabErrorBuilder); Line 277: } Line 278: -- To view, visit https://gerrit.ovirt.org/40680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
