Ramesh N has posted comments on this change. Change subject: webadmin : Handle snapshot create multi-tab validation error ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40680/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java: Line 85: getSnapshotName().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { : @Override : public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { : validate("modelPropertiesChanged");//$NON-NLS-1$ : } : }); : : getDaysOfTheWeek().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { : @Override : public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { : validate("modelPropertiesChanged");//$NON-NLS-1$ : } : }); : : getDaysOfMonth().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { : @Override : public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { : validate("modelPropertiesChanged");//$NON-NLS-1$ : } : }); : : getEndDate().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { : @Override : public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { : validate("modelPropertiesChanged");//$NON-NLS-1$ : } : }); Can we use same listener for all the entities, Because thought we have many listeners here but all of them are doing exactly same. https://gerrit.ovirt.org/#/c/40680/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeSnapshotCreatePopupPresenterWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeSnapshotCreatePopupPresenterWidget.java: Line 59: .editorInvalidityBasedTabControl May be better name with Verb -- To view, visit https://gerrit.ovirt.org/40680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
