Dudi Maroshi has posted comments on this change. Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores) ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/39317/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 671: // validate NUMA nodes count not more then CPUs Line 672: if (getParameters().getVm().getMigrationSupport() == MigrationSupport.PINNED_TO_HOST && Line 673: !validate(VmHandler.checkVmNumaNodesIntegrity(getParameters().getVm(), Line 674: getParameters().getVm(), Line 675: getParameters().isUpdateNuma()))) > missing curly braces. Done Line 676: return false; Line 677: Line 678: return true; Line 679: } -- To view, visit https://gerrit.ovirt.org/39317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
