Roy Golan has posted comments on this change. Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores) ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 22: import org.ovirt.engine.core.bll.snapshots.SnapshotsManager; Line 23: import org.ovirt.engine.core.bll.utils.IconUtils; Line 24: import org.ovirt.engine.core.bll.utils.PermissionSubject; Line 25: import org.ovirt.engine.core.bll.utils.VmDeviceUtils; Line 26: import org.ovirt.engine.core.bll.validator.IconValidator; is this related? Line 27: import org.ovirt.engine.core.bll.validator.VmValidator; Line 28: import org.ovirt.engine.core.bll.validator.VmWatchdogValidator; Line 29: import org.ovirt.engine.core.common.AuditLogType; Line 30: import org.ovirt.engine.core.common.FeatureSupported; https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 38: import org.ovirt.engine.core.common.businessentities.GraphicsType; Line 39: import org.ovirt.engine.core.common.businessentities.GuestAgentStatus; Line 40: import org.ovirt.engine.core.common.businessentities.NumaTuneMode; Line 41: import org.ovirt.engine.core.common.businessentities.Snapshot; Line 42: import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotType; that's a merge problem as well I gues Line 43: import org.ovirt.engine.core.common.businessentities.StorageDomain; Line 44: import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; Line 45: import org.ovirt.engine.core.common.businessentities.UsbPolicy; Line 46: import org.ovirt.engine.core.common.businessentities.VDS; -- To view, visit https://gerrit.ovirt.org/39317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
