Ramesh N has posted comments on this change. Change subject: webadming,engine : Refactored SizeUnit as per IEC binary prefixes ......................................................................
Patch Set 1: Code-Review+1 (2 comments) Had 2 minor comments. https://gerrit.ovirt.org/#/c/40810/1//COMMIT_MSG Commit Message: Line 21: Beyond the scope of this patch(Might need a follow-up patch) : : Refactor SizeUnit units in accordance with the IEC binary prefixes. Is it not contradicting the patch subject?. I could not understand what is beyond the scope of this patch. https://gerrit.ovirt.org/#/c/40810/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java: Line 23: KB May be u can rename the variable name also to KiB, MiB, etc. -- To view, visit https://gerrit.ovirt.org/40810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieacb29c0df8d5355a754a3db15f976a986d771fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
