anmolbabu has posted comments on this change. Change subject: webadming,engine : Refactored SizeUnit as per IEC binary prefixes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40810/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java: Line 23: KB > May be u can rename the variable name also to KiB, MiB, etc. Yes this is what I meant in the commit msg. The changes will be huge if I refactor here bcoz I find a good number of places where these are being used. That's why I thought it is better to get this in for now and later intoduce the patch to refactor enum vars in a subsequent patch so that we are not blocked (for long)from bug being resolved. -- To view, visit https://gerrit.ovirt.org/40810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieacb29c0df8d5355a754a3db15f976a986d771fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
