anmolbabu has posted comments on this change. Change subject: webadmin : Handle snapshot create multi-tab validation error ......................................................................
Patch Set 5: (6 comments) https://gerrit.ovirt.org/#/c/40680/5//COMMIT_MSG Commit Message: Line 24: failures, immaterial of the number of failures in each tab or any Line 25: other criteria, general tab opens up(Does nothing if its already open). Line 26: Line 27: Along with the above this patch also does the following: Line 28: 1. GwtDateTimePicker wasn't extending Composite and hence a > remove this point Done Line 29: ClassCastException was occuring. May be this is now required with Line 30: some change in expectations of some framework class. Fixed this. Line 31: 2. Refactored EntityModelDateTimeBox and GwtDateTimeBox in accordance Line 32: with most other widgets. https://gerrit.ovirt.org/#/c/40680/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java: Line 84: validateModelsOnChangeEvent > This can be renamed to 'initValueChangeListeners' Done Line 91: getSnapshotName().getEntityChangedEvent().addListener(onPropertyChangeValidate) > This listener gets invoked when the cursor is moved to the next field (on b Afrer mouse out/key out from editor Line 291: propName > You could use a boolean here. Something like 'inplaceValidate'. Then below Done https://gerrit.ovirt.org/#/c/40680/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java: Line 152: errorMsgLabel > scheduleTabErrorMessageLabel Done https://gerrit.ovirt.org/#/c/40680/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml: Line 104: errorMsgLabel > Rename this to scheduleTabErrorMessageLabel Done -- To view, visit https://gerrit.ovirt.org/40680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
