Daniel Erez has posted comments on this change.
Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 2132: /**
Line 2133: * Get configuration value from 'cachedConfigValuesPreConvert'
Line 2134: * (raw values from vdc_options table).
Line 2135: */
Line 2136: public static Object GetConfigValue(ConfigurationValues
configValue, String version) {
1. I'll change 'GetConfigValue' to 'GetConfigValuePreConvert'
1. I'll add a new method that gets 'IAsyncConverter'
Line 2137: Map.Entry<ConfigurationValues, String> key =
Line 2138: new KeyValuePairCompat<ConfigurationValues,
String>(configValue, version);
Line 2139:
Line 2140: return cachedConfigValuesPreConvert.get(key);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
Line 321: }
Line 322:
Line 323: protected void raiseLoggedInEvent() {
Line 324: // Cache all configurations values before logging-in
Line 325: AsyncDataProvider.CacheConfigValues(new AsyncQuery(this, new
INewAsyncCallback() {
Need to login for getting Admin configuration values
Line 326: @Override
Line 327: public void OnSuccess(Object target, Object returnValue) {
Line 328: LoginModel loginModel = (LoginModel) target;
Line 329: loginModel.getLoggedInEvent().raise(this,
EventArgs.Empty);
--
To view, visit http://gerrit.ovirt.org/8563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
